Add support list of strings#4
Add support list of strings#4Suh. Junmin (LazyRichard) wants to merge 1 commit intoPSModule:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation to describe the new support for base64 encoding of list outputs, such as those returned by Get-Content.
- Adds a new section for converting a file to base64 with an example.
- Updates the expected output example to match the new multi-string input support.
Files not reviewed (2)
- src/functions/public/ConvertTo-Base64.ps1: Language not supported
- tests/Base64.Tests.ps1: Language not supported
Comments suppressed due to low confidence (1)
README.md:56
- Consider adding a note or an additional test example to clarify how multi-line inputs (lists of strings) are handled during the base64 conversion to ensure the behavior is well documented.
Get-Content file.txt | ConvertTo-Base64
|
Marius Storhaug (@MariusStorhaug) could you review this? |
|
Not sure I would implement it like this. The point you are making is to support pipeline inputs as single item and array, which is fine. The change you are suggesting is a breaking change, when it doesn't have to be. Are you fine if I take your branch and build it out without breaking changes? If you want to do this yourself: Think of the tests as a way to track breaking change. If you have to modify existing test (that is not due to bugs in tests) then its a breaking change. I am not afraid of doing breaking changes as all module are following SemVer, however I do think this doesn't need to be a breaking change. I think we can make both -String and pipeline input available all at once. Challenge accepted or want me to look at it? |
|
Also sorry for being slow on this, for some reason I was not "watching" this repo, as in the built in watch => notification service. ... and thank you for the contribution :) |
Suh. Junmin (LazyRichard)
force-pushed
the
main
branch
from
f92a543 to
bb2d894
Compare
Suh. Junmin (LazyRichard)
force-pushed
the
main
branch
from
bb2d894 to
5c89f76
Compare
|
Thanks for review. My First approach was using ParameterSetName. any guide for this? |
|
All good, just had AI do it for us :) Implemented in the new version that is being built by Copilot as I write. |
|
Thank you for opening the PR. Closing this now as its covered by the other RP. |
Description
This PR supports base64 encoding of the results of functions that return as lists, such as Get-Content.
Rename the parameter to InputData, as in Out-File, Convert-ToJson because the input is now not a simple string.
Type of change
Checklist